Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actionview-svelte-handler to packages #651

Merged
merged 4 commits into from
Jul 28, 2024

Conversation

reesericci
Copy link
Contributor

🎯 Changes

Adds actionview-svelte-handler to packages

βœ… Checklist

  • I have given my PR a descriptive title

Copy link

vercel bot commented Jul 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
sveltesociety-dev βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 28, 2024 2:58pm

Copy link

vercel bot commented Jul 27, 2024

@reesericci is attempting to deploy a commit to the Svelte Society Team on Vercel.

A member of the Team first needs to authorize it.

@reesericci
Copy link
Contributor Author

reesericci commented Jul 27, 2024

This doesn't use NPM, it's a rubygem, so I'm unsure on how to fix this error

@MacFJA
Copy link
Collaborator

MacFJA commented Jul 27, 2024

This doesn't use NPM, it's a rubygem, so I'm unsure on how to fix this error

It's a case we didn't anticipate.

I will open a new PR to allow other package sources

@reesericci
Copy link
Contributor Author

The installation options should be:

Gem

gem install actionview-svelte-handler

Bundler

bundle add actionview-svelte-handler

These are like different ways of installing it, like NPM/PNPM/Yarn

@MacFJA MacFJA mentioned this pull request Jul 27, 2024
2 tasks
@reesericci
Copy link
Contributor Author

Added gem to packages.json, blocked by #652

@MacFJA
Copy link
Collaborator

MacFJA commented Jul 28, 2024

Added gem to packages.json, blocked by #652

The PR #652 have been merged.
Can you rebase your branch, so the validation can be done ?

@reesericci
Copy link
Contributor Author

Rebased!

@MacFJA MacFJA merged commit c54d783 into svelte-society:main Jul 28, 2024
3 of 4 checks passed
@reesericci reesericci deleted the patch-1 branch July 28, 2024 15:33
@MacFJA
Copy link
Collaborator

MacFJA commented Jul 28, 2024

The package is available on the website: https://www.sveltesociety.dev/packages#actionview-svelte-handler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants